Fix use after free when WeakMap is modified during field write #7671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
approved these changes
Nov 20, 2021
(When a value's destructor triggers a resizing or rehashing of the WeakMap)
TysonAndre
force-pushed
the
weakmap-dtor-order
branch
from
c107140 to
f6d70e9
Compare
Test failure is spurious and unrelated https://dev.azure.com/phpazuredevops/PHP/_build/results?buildId=21640&view=logs&j=98767452-adc9-546f-46a7-4bcf997bf1db&t=afaea366-bdd0-56b2-e5f3-adec9091eeb8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(When a value's destructor triggers a resizing or rehashing of the WeakMap)
Prior to this PR, this test case would cause errors with
USE_ZEND_ALLOC=0ormake test TESTS=-m(impliesUSE_ZEND_ALLOC=0)(This type of issue is similar to another (fixed) bug I reported for SplFixedArray - https://bugs.php.net/bug.php?id=81429)